Review main Merged

67622[TASK] Use d3 v6 microlibraries

Benjamin Franzke CR +2 V +2 Hard +94 −286 updated 02/02/21, 13:20

Commit message

In order to avoid loading an unnecessarily large complete d3 bundle,
we now only pull in the small amount of modules we actually need.

d3.transition() is replaced by the native web animation api, as
d3-transition would pull in 4 more libraries
(d3-color, d3-ease, d3-interpolate and d3-timer).
d3-dispatch could easily be replaced by native CustomEvents, but
it is a dependency of d3-drag and therefore shipped right now.

This change reduces load size from 262K to 19K.

yarn remove d3
yarn add d3-dispatch d3-drag d3-selection
grunt build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16