67634[TASK] Move help button of access module to the toolbar
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Oli Bartsch +1
-
Verified V +2 Done
- Richard Haeser +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 812
-
Georg Ringer uploaded patch set 1 02/03/21, 10:40
-
Georg Ringer commented on patch set 1 02/03/21, 10:40
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 02/03/21, 10:46 Completed build in 05m 40s on Wed, 3 Feb, 10:46 AM Test Summary: 1 of 27544 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9209
-
TYPO3com commented on patch set 1 02/03/21, 13:08 Completed build in 2h 33m 37s on Wed, 3 Feb, 01:08 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9209
-
TYPO3com commented on patch set 1 02/03/21, 13:19 Completed build in 5h 11m 47s on Wed, 3 Feb, 01:19 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9209
-
TYPO3com voted on patch set 1 V +1 02/03/21, 16:43 Completed build in 07m 10s on Wed, 3 Feb, 04:43 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9218
-
Oli Bartsch commented on patch set 1 V +1 CR +1 02/03/21, 16:57
Good catch. -
Richard Haeser commented on patch set 1 02/03/21, 20:36
I do have a styling issue I'm afraid. See https://www.richardhaeser.com/fileadmin/ScreenshotsForIssues/Screenshot_2021-02-03_at_21.35.34.png -
Georg Ringer commented on patch set 1 02/03/21, 21:06
Reply
those styling issues are also in e.g scheduler module and are not related to this particular issue - do you agree? -
Richard Haeser commented on patch set 1 02/03/21, 21:09
Reply
Yeah, I see it now indeed. Is there already a forge issue for that? By making it more consistent and move the button (which I really like) we introduce a new problem that the text is not readable. So I think we should give the styling issue a bit more priority as well. -
Richard Haeser voted on patch set 1 V +2 CR +2 02/03/21, 21:10
-
Richard Haeser merged patch set 2 02/03/21, 21:10