Review main Merged

67658[TASK] Load TypeScript declarations for sortablejs

Andreas Kienast CR +2 V +2 Normal +47 −6 updated 02/06/21, 21:21

Commit message

This patch adds the TypeScript declaration for the sortablejs library.
Since the imported module has a different naming, the PageRenderer needs
both the new module name ("sortablejs") and the old name ("Sortable") as
this would be a breaking change, otherwise.

In the master patch, the old module name has been declared deprecated.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9