Review 10.4 Merged

67659[BUGFIX] Fix frameset module property for FileList

Andreas Kienast CR +2 V +2 Easy +11 −4 updated 02/08/21, 18:43

Commit message

BackendController::generateJavascript() creates the
top.fsMod object to provide frameset modules an easy
way of storing their state. The FileList module e.g.
stores the current folder identifier. Therefore, after
switching back to the FileList module, the previously
selected folder is used.

This behaviour is now restored by replacing the
"instanceof" check, which always evaluated to FALSE,
with a typeof check. It's furthermore now ensured
that the id will always be set, even if recentIds
is not yet an object.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2