Review main Merged

67675[TASK] Add <typo3-backend-icon> component

Benjamin Franzke CR +2 V +2 Expert +1337 −114 updated 03/01/21, 10:35

Commit message

The component is provided as replacement for the
current lit-helper `icon()` which cannot provide
support for icon usage inside shadow dom elements.

The component renders all icons as inline SVGs.
FontawesomeIconProvider is therefore adapted
to provide inline rendered SVGs for font-awesome
icons. Not that these inline font-awesome SVGs
will also be used in areas where 'inline' icons are
requested (like information toolbar) but the
fallback to 'default' was used before.

The component supports all properties of the
Icon API via HTML attributes.
Colors and custom sizes can be applied to the
component via CSS color/font-size property:

typo3-backend-icon[identifier=status-dialog-information] {
  color:#6daae0;
  /* An explicit font-size will be used as icon width & height */
  font-size: 1.2em;
}

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 22

Show 2 more files