Review main Merged

67678[TASK] Inject cache into IconRegistry

Benjamin Franzke CR +2 V +2 Normal +39 −70 updated 02/25/21, 17:26

Commit message

This is to avoid calling IconRegistry::setCache during early bootstrap.
That hack was needed back when CacheManager was streamlined to
only be usable after ext_localconf has been loaded (#86353).
Since DI was not available back then, assets cache needed to injected
statically. Now that DI is available, we can inject withing the factory.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6