Review main Abandoned

67681[TASK] Move reset button in user settings to the toolbar

Georg Ringer CR 0 V 0 Easy +17 −12 updated 05/05/21, 18:09

Commit message

The reset button should be in the toolbar and not hidden somewhere
between the fields in a tab.

This improves the usability by reducing clicks and also makes it more
clear that this doesn't save any modified values at the same time.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 913

  1. Georg Ringer uploaded patch set 1 02/09/21, 20:56

  2. Georg Ringer commented on patch set 1 02/09/21, 20:57

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 02/09/21, 21:05 Completed build in 09m 00s on Tue, 9 Feb, 09:05 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9412

  4. core-ci voted on patch set 1 V +1 02/09/21, 21:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/550

  5. Benjamin Franzke commented on patch set 1 CR -1 02/09/21, 21:17

    The back/refresh icon, especially inside the toolbar – next to the save button – looks like a button that is used to reset the *current* form changes. Reverting all configuration isn't what a user expects in that case. It's common to provide such functionality in a rather hidden area, together will color that depicts that a reset is not advisable in general. (so if we want to improve something, that the user should be warned by coloring the button appropriately.
  6. Markus Klein commented on patch set 1 02/09/21, 21:39

    Reply

    I agree. I first think of the "danger zone" on github in the repo settings.
  7. Georg Ringer uploaded patch set 2 02/24/21, 20:57

  8. TYPO3com voted on patch set 2 V +1 02/24/21, 21:05 Completed build in 08m 37s on Wed, 24 Feb, 09:05 PM Test Summary: 32704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9708

  9. core-ci voted on patch set 2 V +1 02/24/21, 21:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/982

  10. Christian Kuhn commented on patch set 2 V -1 02/25/21, 16:09

    Hmm. Current state of this patch does not feel like an improvement: This big red box is now always there, looking as if the user did something wrong, which is not the case.
  11. Oli Bartsch commented on patch set 2 02/25/21, 16:23

    Reply

    This does IMO also not comply to the overall UX in the backend. I don't know any other module, which displays a callout below the module content. We should furthermore adjust the button label since this could easily be misinterpreted as resetting the whole user settings, including e.g. activated MFA providers.
  12. Christian Kuhn commented on patch set 2 05/05/21, 18:09

    Hey Georg. For the sake of a cleaner gerrit, I'll abandon this patch for now. Hope it's ok with you. Feel free to resurrect or further work on it to re-discuss.
  13. Christian Kuhn abandoned the change 05/05/21, 18:09