Review main Merged

67683[TASK] Clean up SvgTree code

Benni Mack CR +2 V +2 Hard +265 −357 updated 02/10/21, 19:38

Commit message

Now that jQuery has gone and TypeScript is in place for Tree components,
the next step is to consolidate and sort out re-usability.

This change prepares the way for allowing multiple trees in the
navigation component area (for FileStorageTree).

* ContextMenu allows int+number (which is correct)
* ContextMenu has all information from the TreeNode (and not the SVG
  element) - less Markup!
* KeyTypeEnums are used throughout SvgTree
* Centralized place for error notifications, removing duplicate code
* tree.settings.isDragAnDrop is removed in favor of
  tree.settings.allowDragMove (which already exists)
* Unused properties in TreeNode are removed
* Since we are now in "TS module land", PageTreeToolbar.ts is removed
  because the class is only used in the PageTreeElement, so it does
  not need to be exposed anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14