Review main Merged

67691[TASK] Use position sticky for docheader

Benjamin Franzke CR +2 V +2 Normal +43 −71 updated 02/12/21, 20:48

Commit message

Avoid JavaScript based offset and height calculations.
Position sticky can do that in all supported browsers for us.

.module-docheader is additionally adapted to use display:flex
in order for the docheader-bar margins to be contained within.
(to preserve the position:fixed behaviour, which did the same).

While at it, we also avoid jQuery usage within DocumentHeader.ts

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8