Review 10.4 Merged

67712[BUGFIX] Silently resolve invalid current page in paginator

Oli Bartsch CR +2 V +2 Normal +53 −5 updated 02/11/21, 14:20

Commit message

Passing a current page number which exceeds the maximum
number of pages to the paginator is now silently resolved
by using the last available page as the current page. This
is done to prevent empty results, since such value can be
passed unintentionally by a user. For example in case some
internal state changed after the view was initially rendered
or the view does not perform checks on this value at all.

The later will now be prevented at least in core by adding
the "max" attribute to all core paginations which previously
missed it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 35

  1. Oli Bartsch uploaded patch set 1 02/11/21, 13:40

  2. TYPO3com voted on patch set 1 V +1 02/11/21, 13:51 Completed build in 10m 02s on Thu, 11 Feb, 01:51 PM Test Summary: 75320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1088

  3. core-ci voted on patch set 1 V +1 02/11/21, 13:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/644

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/11/21, 14:20

  5. Christian Kuhn merged patch set 2 02/11/21, 14:20