Review main Merged

6775[BUGFIX] Shortcut page does not keep 'type' parameter

Xavier Perseguers CR +2 V +2 Easy +7 −1 updated 06/03/13, 20:49

Commit message

When a shortcut page is accessed with ?type=123 in the URL, the
redirect is calculated without this parameter.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Stefan Neufeind +1
    • Oliver Hader +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Oliver Hader +1

Files 1

Review log 11

  1. Tolleiv Nietsch merged patch set 1 01/18/12, 10:53

  2. Tolleiv Nietsch commented on patch set 2 V 0 01/18/12, 10:53

    by team member; Looks good to me, approved
  3. Stefan Neufeind commented on patch set 2 01/18/12, 10:53

    Looks good to me, but someone else must approve
  4. Oliver Hader uploaded patch set 2 01/18/12, 10:53

  5. Oliver Hader commented on patch set 2 01/18/12, 10:53

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:1, R:1 from Thierry Brodard <thierry.brodard@gmail.com>
  6. Xavier Perseguers commented on patch set 1 01/18/12, 10:53

    (1 inline comment)
  7. Helmut Hummel commented on patch set 1 01/18/12, 10:53

    (1 inline comment)

    class.tslib_fe.php:2693

    Instead of a special handling of "type" I would rather use addQueryString to pass all parameters to the redirect.
  8. Thierry Brodard commented on patch set 1 01/18/12, 10:53

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 01/18/12, 10:53

  10. Mr. Jenkins commented on patch set 2 01/18/12, 10:53

  11. Oliver Hader commented on patch set 2 01/18/12, 10:53

    "My vote" on this was given automatically to summarize previous votes (see accordant post in v4 list). This change only works for the root page and I don't think it's the right approach. Using "config.linkVars = type" is the correct one since you probably want to stay on that type...