Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
67912[FEATURE] allow TypoScript's select without constraint of uid or pid
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/67912/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/67912/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 1
Review log 1421
-
Ayke Halder uploaded patch set 1 02/12/21, 11:29
-
TYPO3com voted on patch set 1 V +1 02/12/21, 11:37 Completed build in 08m 18s on Fri, 12 Feb, 11:37 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9500
-
core-ci voted on patch set 1 V +1 02/12/21, 11:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/686
-
Oliver Hader commented on patch set 1 CR -1 02/24/21, 08:58
I see the intention of having some behavior like this. On of the reasons for `pidInList` is to deny access to system tables (most of them actually stored on `pid=0`), like `be_users`. -
Ayke Halder commented on patch set 1 02/24/21, 10:09
I just looked into your point. The mentioned behaviour is already possible. Please have a look at https://forge.typo3.org/issues/91718 and pidInList - special value '0': https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Functions/Select.html#pidinlistReply
I see your point. But this patch does not change the behaviour of `pidInList = 0` - which is already implemented and disables `pid`-check as long as you set an `uidInList`constraint. E.g. it is already possible to make a query to `be_users` by setting `pidInList = 0` and "guessing" `be_users`-ids with `uidInList = 1,2,3,4,5,…` This patch only enables queries without setting the `uid`-constraint at all. -
Ayke Halder uploaded patch set 2 03/23/21, 12:21
-
TYPO3com voted on patch set 2 V +1 03/23/21, 12:31 Completed build in 10m 15s on Tue, 23 Mar, 12:31 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10310
-
core-ci voted on patch set 2 V -1 03/23/21, 12:36 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1786
-
Christian Kuhn rebased onto patch set 3 03/23/21, 16:14
-
TYPO3com voted on patch set 3 V +1 03/23/21, 16:21 Completed build in 06m 34s on Tue, 23 Mar, 04:21 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10315
-
core-ci voted on patch set 3 V +1 03/23/21, 16:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1790
-
Benni Mack wrote 11/29/21, 10:02
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 13:15
-
core-ci voted on patch set 4 V +1 11/29/21, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19996
-
Oliver Klee commented on patch set 4 07/16/23, 11:11
How should we continue here? -
Ayke Halder commented on patch set 4 07/17/23, 13:25
Reply
I still like to see this implemented. A side case has been found where checking for '0' is not working correctly - see issue on Forge. So I propose to add a completely new config parameter 'disabled': uidInList = disabled pidInList = disabled -
Oliver Klee commented on patch set 4 07/17/23, 13:33
Reply
Would you be willing to cover this (i.e., the relevant cases) with a test? -
Ayke Halder commented on patch set 4 07/17/23, 13:59
Reply Unresolved
-
Oliver Klee wrote 08/25/24, 10:13
Removed cc Oliver Klee. -
Benni Mack marked it work in progress 02/10/25, 15:59