67921[BUGFIX] Non admin can't see xMOD_alt_doc.php shortcuts
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 36
-
TYPO3com uploaded patch set 1 02/15/21, 10:01
-
TYPO3com voted on patch set 1 V +1 02/15/21, 10:10 Completed build in 09m 19s on Mon, 15 Feb, 10:10 AM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1098
-
core-ci voted on patch set 1 V +1 02/15/21, 10:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/728
-
Christian Kuhn commented on patch set 1 CR -1 02/25/21, 17:40
-
Vincent commented on patch set 1 04/29/21, 15:14
ShortcutRepository.php:726Reply UnresolvedIn fact, here https://git-t3o.typo3.org/TYPO3/CMS/-/blob/10.4/typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php#L525 it checks for a pageId returned by extractPageIdFromShortcutUrl when the user isn't admin but for shortcuts like edit, le pageId is only present in the returnUrl argument so we have to decode the entire shortcut URL for the regex to work. -
Oli Bartsch abandoned the change 07/12/21, 18:30
This has already been fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/69765
ShortcutRepository.php:726