Review 10.4 Abandoned

67921[BUGFIX] Non admin can't see xMOD_alt_doc.php shortcuts

TYPO3com CR 0 V 0 Easy +1 −1 updated 07/12/21, 18:30

Commit message

Prevent id= not found in the url ...returnUrl=*encoded*...

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 36

  1. TYPO3com uploaded patch set 1 02/15/21, 10:01

  2. TYPO3com voted on patch set 1 V +1 02/15/21, 10:10 Completed build in 09m 19s on Mon, 15 Feb, 10:10 AM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1098

  3. core-ci voted on patch set 1 V +1 02/15/21, 10:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/728

  4. Christian Kuhn commented on patch set 1 CR -1 02/25/21, 17:40

    ShortcutRepository.php:726

    Thanks for patch! This looks odd: It looks as if the encoded returnUrl is decoded here to fetch the 'id=' param from returnUrl, which shouldn't be correct. I'm unsure how to proceed here. I think the issue on forge should receive a 'how-to-reproduce' to see what the patch tries to achieve. I'll -1 the patch for now in the hope the author gives some more explanation (here, or in the issue). In master, this code has been fully refactored, so 'only' v10 is affected in the first place.
  5. Vincent commented on patch set 1 04/29/21, 15:14

    ShortcutRepository.php:726 Reply Unresolved

    In fact, here https://git-t3o.typo3.org/TYPO3/CMS/-/blob/10.4/typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php#L525 it checks for a pageId returned by extractPageIdFromShortcutUrl when the user isn't admin but for shortcuts like edit, le pageId is only present in the returnUrl argument so we have to decode the entire shortcut URL for the regex to work.
  6. Oli Bartsch abandoned the change 07/12/21, 18:30