Review main Merged

67993[TASK] MFA providers should check their internal state

Oli Bartsch CR +2 V +2 Normal +112 −42 updated 02/22/21, 22:12

Commit message

Since there are use cases in which the internal state of a provider may
have changed since the view was initially rendered (e.g. when using
multiple tabs), the provider has to check internal state prior the
execution of the requested operation.

This patch furthermore performs some clean ups:

* Fix some typos
* Check if the requested action can be performed on the given provider
* Add missing exception in case a non existent provider is being updated
* Use existing isSystemMaintainer() method over manual evaluation
* Prevent provider setup instructions to grow too large

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13