Review main Abandoned

68134[BUGFIX] Handle multiselect fields properly

Philipp Kitzberger CR 0 V -1 Normal +48 −21 updated 11/10/26, 13:32

Commit message

When using a multiselect field marker within a subject, e.g.
{multiselect-1} an exception is thrown.

This patch fixes the behavior, i.e. the labels of the chosen
multiselect field options are returned as a comma-separated
list.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 3

Review log 4971

Show 3146 earlier messages
  1. Philipp Kitzberger uploaded patch set 1 02/26/21, 20:39

  2. TYPO3com voted on patch set 1 V -1 02/26/21, 20:39 Completed build in 13s on Fri, 26 Feb, 08:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9740

  3. Georg Ringer commented on patch set 1 03/01/21, 10:30

    IMO multiple support requires far more work, I just spent some hours to make that work in v10 and will release that as custom extension. contact me on slack if interested
  4. Benni Mack commented on patch set 1 11/04/21, 11:23

    Any way on how to continue here @philipp or @georg? Do you have an extension ready yet?
  5. Philipp Kitzberger commented on patch set 1 11/04/21, 12:04

    @Benni, Georg and I had a little chat on slack that very day and figured out that Georg was talking about something unrelated to this topic here.
  6. Benni Mack commented on patch set 1 11/04/21, 12:05

    Reply

    Ah, OK. So we need to make sure to get the tests "green", correct?
  7. Benni Mack rebased onto patch set 2 11/04/21, 12:05

  8. core-ci voted on patch set 2 V -1 11/04/21, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18873

  9. Benni Mack commented on patch set 3 11/09/21, 12:43

    Published edit on patch set 2.
  10. core-ci voted on patch set 3 V -1 11/09/21, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19067

  11. Benni Mack updated the commit message in patch set 4 11/18/21, 10:45

  12. core-ci voted on patch set 4 V -1 11/18/21, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19465

  13. Benni Mack wrote 11/28/21, 22:06

    Removed cc Benni Mack.
  14. Benni Mack wrote 11/29/21, 10:21

    Change destination moved from master to main
  15. Benni Mack updated the commit message in patch set 5 11/29/21, 14:11

  16. core-ci voted on patch set 5 V -1 11/29/21, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20117

  17. till-s till-s commented on patch set 5 V +1 12/16/21, 13:23

    The field values area returned correctly now.
  18. Benni Mack rebased onto patch set 6 12/16/21, 13:29

  19. core-ci voted on patch set 6 V -1 12/16/21, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21181

  20. Benni Mack commented on patch set 6 12/20/21, 09:56

    Hey Philipp, quick check here. Wouldn't it make sense to give the Element a "valueToString" method?
  21. Philipp Kitzberger uploaded patch set 7 12/22/21, 15:05

  22. core-ci voted on patch set 7 V -1 12/22/21, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21401

  23. Björn Jacob updated the commit message in patch set 8 06/29/22, 08:02

  24. core-ci voted on patch set 8 V -1 06/29/22, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28469

  25. till-s till-s commented on patch set 8 09/28/22, 06:56

    Hi, is this bug still being tracked? The issue still persists and it seems that the PR just needs to be merged.
  26. Philipp Kitzberger rebased onto patch set 9 10/13/22, 13:24

  27. Philipp Kitzberger commented on patch set 9 10/13/22, 13:26

    Reply

    i guess ;-) what do you think of patchset 8?
  28. core-ci voted on patch set 9 V -1 10/13/22, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32290

  29. Stefan Bürk commented on patch set 9 10/13/22, 15:17

    Reply

    You should have a look into the "red" pipeline. Tests are failing, bevause of type errors. Either not properly setup in tests or real issues. And phpstan is complaining also. Simply repushing will not get them green.
  30. Philipp Kitzberger uploaded patch set 10 10/13/22, 15:18

  31. Philipp Kitzberger commented on patch set 10 10/13/22, 15:22

    Reply

    The previous test run failed due to some other error (network?). Only the re-run showed me the cause of the problem. Didn't know how to trigger a re-run without pushing... Sorry. Patch set 10 should be fine though.
  32. core-ci voted on patch set 10 V -1 10/13/22, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32298

  33. Stefan Bürk commented on patch set 10 10/13/22, 15:34

    Reply

    Running them locally (docker + docker-compose cli script required ). For still failing unit tests: ``` Build/Scripts/runTests.sh -s unit -p 8.1 ``` Pipeline displays which commands are executed, so can be reproduced locally. And with adding "-x" to the mix xdebugged if breakpoints are set etc. ``` Build/Scripts/runTests.sh -h ``` display a generic list of tasks and options. Yeah ... the "OCI runtime " failers has been a issue with gitlab runners while back. Not saw them, just peeked into the last failed pipeline and not into all of them. But still, unit tests are still failing.
  34. Benni Mack updated the commit message in patch set 11 V -1 05/03/23, 09:24

  35. core-ci voted on patch set 11 V -1 05/03/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41407

  36. Oliver Hader rebased onto patch set 12 V -1 05/03/23, 12:39

  37. core-ci voted on patch set 12 V -1 05/03/23, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41529

  38. Parikshit Pingle updated the commit message in patch set 13 V -1 05/04/23, 09:14

  39. core-ci voted on patch set 13 V -1 05/04/23, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41569

  40. Jasmina Ließmann updated the commit message in patch set 14 V -1 05/04/23, 12:06

  41. core-ci voted on patch set 14 V -1 05/04/23, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41571

  42. till-s till-s commented on patch set 14 04/18/24, 14:33

    Reply

    @benni@typo3.org is there any chance this patch can be merged?
  43. Philipp Kitzberger uploaded patch set 15 V -1 04/18/24, 15:21

  44. core-ci voted on patch set 15 V -1 04/18/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56267

  45. Benni Mack commented on patch set 15 04/18/24, 21:35

    Reply

    once the CI pipeline is green, yes.
  46. Philipp Kitzberger rebased onto patch set 16 V -1 10/20/24, 15:22

  1. core-ci voted on patch set 16 V -1 10/20/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68262

  2. Philipp Kitzberger uploaded patch set 17 V -1 10/21/24, 09:38

  3. core-ci voted on patch set 17 V -1 10/21/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68291

  4. Philipp Kitzberger uploaded patch set 18 V -1 10/21/24, 10:24

  5. core-ci voted on patch set 18 V +1 10/21/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68293

  6. Philipp Kitzberger commented on patch set 18 10/21/24, 10:32

    Reply

    I've just rebased this patch. AbstractFinisherTest was failing, so I adjusted those. One is obsolete now and got removed: substituteRuntimeReferencesThrowsExceptionOnMultipleVariablesResolvedAsArray
  7. Philipp Kitzberger rebased onto patch set 19 V +1 03/26/25, 14:02

  8. Benni Mack commented on patch set 19 03/26/25, 14:02

    Reply

    Done
    ready to review
  9. Benni Mack commented on patch set 19 03/26/25, 14:02

    Reply

    Done

    Reply

    Done
  10. Benni Mack updated the commit message in patch set 20 03/26/25, 14:03

  11. core-ci voted on patch set 19 V +1 03/26/25, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76386

  12. core-ci voted on patch set 20 V +1 03/26/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76387

  13. Benni Mack voted on patch set 20 CR +1 V +1 03/26/25, 14:48

  14. Benni Mack commented on patch set 20 CR 0 V 0 03/26/25, 16:15

    how about we add then StringableFormElementInterface to the Select instead?
  15. Stefan Oswald commented on patch set 20 CR +1 V +1 05/06/25, 06:54

    The bugfix message should also explain that not only "mustiselect" fields are fixed with this, but also "multicheckbox" fields.
  16. Ayke Halder commented on patch set 20 CR -1 12/17/25, 19:33

    AbstractFinisherTest.php:160

    AFAIK this is the test input, isn't it? By changing the input from `array` to `string`, the test of course does not fail anymore - as it tests with `string` input now. The intention of this test actually was to show if the code works with an input of type `array`. So if we keep the test input type as `array` here, the test still fails: ``` Cannot convert object value of "element-identifier-1" to string ```
  17. Ayke Halder uploaded patch set 21 CR +1 V +1 12/17/25, 20:09

  18. core-ci voted on patch set 21 V +1 12/17/25, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92372

  19. Ayke Halder commented on patch set 21 CR +1 12/17/25, 20:29

    AbstractFinisherTest.php:160 Reply

    The test is refactored.
  20. Christian Rath-Ulrich voted on patch set 21 CR +1 V +1 01/15/26, 11:29

  21. Josua Vogel commented on patch set 21 01/19/26, 08:40

    Unresolved

    Some time ago, I provided a similar bug fix that fixes additional issues and, in my opinion, structures everything a little better (not everything in GenericFormElement): https://review.typo3.org/c/Packages/TYPO3.CMS/+/90056

    GenericFormElement.php:37 Unresolved

    As far as I can see, there is no indication anywhere that there is a “glue” property. In my opinion, this should be defined in MultiSelect.yaml, e.g. as a predefined default.
  22. Benni Mack wrote 04/21/26, 14:54

    Removed reviewer Benni Mack.
  23. Benni Mack updated the commit message in patch set 22 CR +1 V +1 04/22/26, 06:48

  24. core-ci voted on patch set 22 V -1 04/22/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100805

  25. Benni Mack abandoned the change 11/10/26, 13:32