Review 9.5 Merged

68136[TASK] Drop an always skipped unit test

Christian Kuhn CR +2 V +2 Easy +1 −43 updated 02/27/21, 09:21

Commit message

* Test relies on xdebug, which is not available on CI, this
  test is never executed there.
* Since the low level API header() is tested, the test
  additionally needs to fork a php process to do it's thing.
  This is ugly for a unit test.
* Turning the test into a functional test won't improve the
  situation since the response emitting is not done with
  functional sub requests.
* The skip logic breaks with xdebug 3.0 using xdebug.mode=off.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2