Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
68148[FEATURE] Add video platform name to iframe title
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 22
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/68148/22 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/68148/22 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php6+35 −0
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php5+35 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rstnew+31 −0
- typo3/sysext/core/Resources/Private/Language/locallang_common.xlf+6 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+34 −15
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+48 −29
- typo3/sysext/core/ext_localconf.php+8 −0
Review log 73111
Show 5586 earlier messages
-
Martin Kutschker uploaded patch set 1 02/28/21, 10:09
-
TYPO3com voted on patch set 1 V -1 02/28/21, 10:18 Completed build in 09m 05s on Sun, 28 Feb, 10:18 AM Test Summary: 2 of 32971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9761
-
core-ci voted on patch set 1 V -1 02/28/21, 10:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1064
-
Martin Kutschker uploaded patch set 2 02/28/21, 10:35
-
TYPO3com voted on patch set 2 V +1 02/28/21, 10:42 Completed build in 06m 24s on Sun, 28 Feb, 10:42 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9763
-
core-ci voted on patch set 2 V -1 02/28/21, 10:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1065
-
Christian Kuhn rebased onto patch set 3 02/28/21, 11:18
-
TYPO3com voted on patch set 3 V -1 02/28/21, 11:25 Completed build in 06m 09s on Sun, 28 Feb, 11:25 AM Test Summary: 1 of 32971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9764
-
core-ci voted on patch set 3 V +1 02/28/21, 11:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1066
-
TYPO3com voted on patch set 3 V +1 02/28/21, 11:32 Completed build in 19m 44s on Sun, 28 Feb, 11:32 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9764
-
Jonas Eberle commented on patch set 3 V +1 02/28/21, 12:16
When giving a custom title (<f:media title="myTitle" file="{m}" />), the title on the iframe is "YouTube video myTitle" - which is fine IMHO. I guess it needs a feature .rst? -
Guido Schmechel commented on patch set 3 03/01/21, 09:32
First: I like the approach! You refactor a lot, for actually a small change. If you're already at it: Does it make sense to create an interface for the video classes? You can also add your own OnlineVideoHelper. (Of course possible as a follow-up ticket) See https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.5/Feature-61799-ImprovedHandlingOfOnlineMedia.html -
Guido Schmechel commented on patch set 3 03/01/21, 09:36
Reply
Ah. There is already an interface. Maybe we can update it for createVideoUrl? -
Georg Ringer commented on patch set 3 CR -1 03/02/21, 20:01
please don't mix different changes into one. there is no need for an abstract class to change the iframe rendering -
Martin Kutschker commented on patch set 3 03/02/21, 20:16
Reply
I would have had to duplicate the change in collectIframeAttributes without that refactoring. Do I get a +1 if I split the patch?Reply
The form of the totle has been discussed by the a11y team. Adding a rst is no problem. -
Martin Kutschker uploaded patch set 4 03/15/21, 20:42
-
Martin Kutschker wrote 03/15/21, 20:44
Description of patch set 4 set to "This time without refactoring or type-safety improvements" -
TYPO3com voted on patch set 4 V +1 03/15/21, 20:49 Completed build in 06m 55s on Mon, 15 Mar, 08:49 PM Test Summary: 32703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10145
-
core-ci voted on patch set 4 V +1 03/15/21, 20:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1562
-
Oli Bartsch commented on patch set 4 CR -1 03/15/21, 21:50
The rst is still missing, therefore -1.VimeoRenderer.php:208I can't get used to the idea of having a hardcoded label here. As an integrator, I want to have the ability to define whatever markup is being renderer in the frontend, especially when it comes to visible components like labels. So, from my point of view, this should be - easily - configurable, e.g. by adding a custom label key via TypoScript. Otherwise we force people to either use `locallangXMLOverride` or to overwrite the complete renderer. Besides that, is there a reason why you include the whole language file instead of just using `$this->getLanguageService()->sL()`? Also do I miss a trim() here. This currently leads to title="Vimeo video " with the trailing whitespace, if the option isn't provided. -
Martin Kutschker commented on patch set 4 03/16/21, 08:34
VimeoRenderer.php:208ReplyThe renderer is used also in the backend and called indirectly from FE code. If you can think of a way to add customization of the label feel free to add it. I couldn't find a way to add this functionality. No special reason for not using $this->getLanguageService()->sL(). Can be used if it is better (why?). The trailing space was of no concern to me, adding trim() is fine. -
Oli Bartsch commented on patch set 4 03/16/21, 11:53
VimeoRenderer.php:208ReplyCould be done the same as in the line above with the `doctype`. In case TSFE is available (FE context) and the key, e.g. `config.iframeVideoPrefix`, is set, use it. Otherwise if not provided (e.g. in BE context) the default label is used. I would prefer to use sL() since it seems like there is no need to load the whole locallang file. Especially if the additional config key is added, you don't know the users locallang file or if he maybe just adds a plain text. In this case sL() has to be used anyways. So this could look like: if (($GLOBALS['TSFE'] ?? null) instance of TypoScriptFrontendController && ($GLOBALS['TSFE']->config['config']['iframeVideoPrefix'] ?? '') !== '') { $prefixLabel = $GLOBALS['TSFE']->config['config']['iframeVideoPrefix']; } else { $prefixLabel = 'EXT:core/Resources/Private/Language/locallang_common.xlf:vimeoVideoPrefix'; } $options['title'] = trim($this->getLanguageService()->sL($prefixLabel) . ' ' . $options['title']); -
Martin Kutschker uploaded patch set 5 03/19/21, 16:40
-
TYPO3com voted on patch set 5 V -1 03/19/21, 16:41 Completed build in 17s on Fri, 19 Mar, 04:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10241
-
Martin Kutschker commented on patch set 4 03/19/21, 16:41
Reply
Added. -
core-ci voted on patch set 5 V -1 03/19/21, 16:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1699
-
Martin Kutschker uploaded patch set 6 03/19/21, 16:47
-
TYPO3com voted on patch set 6 V -1 03/19/21, 16:54 Completed build in 07m 40s on Fri, 19 Mar, 04:54 PM Test Summary: 32911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10242
-
core-ci voted on patch set 6 V -1 03/19/21, 16:57 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1700
-
Martin Kutschker commented on patch set 6 03/19/21, 17:11
VimeoRenderer.php:208ReplyClass TypoScriptFrontendController is not available in extension Core. -
Martin Kutschker uploaded patch set 7 03/19/21, 17:11
-
TYPO3com voted on patch set 7 V +1 03/19/21, 17:18 Completed build in 07m 15s on Fri, 19 Mar, 05:18 PM Test Summary: 32911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10244
-
core-ci voted on patch set 7 V +1 03/19/21, 17:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1702
-
Jonas Eberle uploaded patch set 8 03/20/21, 09:09
-
Jonas Eberle voted on patch set 8 V +1 03/20/21, 09:11
-
TYPO3com voted on patch set 8 V +1 03/20/21, 09:17 Completed build in 07m 47s on Sat, 20 Mar, 09:17 AM Test Summary: 32911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10246
-
core-ci voted on patch set 8 V +1 03/20/21, 09:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1707
-
Guido Schmechel commented on patch set 8 V -1 03/20/21, 10:03
Backend view is fine. But in the frontend I get the following message: "Return value of TYPO3\CMS\Core\Resource\Rendering\YouTubeRenderer::getLanguageService() must be an instance of TYPO3\CMS\Core\Localization\LanguageService, null returned" So -1 for now to find out if this a local problem or a patch problem -
Martin Kutschker commented on patch set 8 03/21/21, 12:46
Reply
I have tested again. I have no issues in a clean instance. -
Guido Schmechel commented on patch set 8 V 0 03/21/21, 15:50
Reply
Mh okay. I'll withdraw my -1 for now and wait for the other reviews. -
Torben Hansen commented on patch set 8 V -1 03/28/21, 06:40
I also get the mentioned exception "TYPO3\CMS\Core\Localization\LanguageService, null returned" Exception is thrown when page is in uncached state und no active BE session exist. Reason: $GLOBALS['LANG'] is only available in backend context. In frontend context TSFE->sL should be used. I'm also really unsure if we need new TypoScript settings at "config" level to define the prefix labels. IMO it would be better to use language files only. If an integrator requires to override the prefix labels, locallangXMLOverride can be used. -
Oli Bartsch commented on patch set 8 03/28/21, 21:40
Reply
Hi Torben, it was actually my suggestion to use the new config key. See the comment regarding my thoughts: > I can't get used to the idea of having a hardcoded label here. As an integrator, I want to have the ability to define whatever markup is being renderer in the frontend, especially when it comes to visible components like labels. So, from my point of view, this should be - easily - configurable, e.g. by adding a custom label key via TypoScript. Otherwise we force people to either use `locallangXMLOverride` or to overwrite the complete renderer. While I'm fully for not introducing new config keys for everything, it is IMO necessary here. We introduce markup being rendered in the frontend without asking the integrator, so we force them to tackle it. Having 20+ languages in an installation would then lead to 20+ new lines in ext_localconf, since you need to override each language individually. -
Torben Hansen commented on patch set 8 04/01/21, 09:04
Reply Unresolved
Thanks for pointing me the the discussion about the new config keys. I somehow missed that and I'm fine with the new config keys. However, the patch still fails with an exception because $GLOBALS['LANG'] is used in FE context. -
Jonas Eberle commented on patch set 8 04/01/21, 13:59
The notice in LanguageService says: * Usually this is injected into $GLOBALS['LANG'] when in backend or CLI context, and * populated by the current backend user. Don't rely on $GLOBAL['LANG'] in frontend, as it is only * available in certain circumstances! I've seen multiple ways to get hold of ->sL in the current code base but I'll just try simple constructor injection. Don't forget to clear caches via InstallTool. For reference: I am not sure if this is still needed https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Information/Typo3Information.php#L38 -
Jonas Eberle uploaded patch set 9 04/01/21, 14:40
-
TYPO3com voted on patch set 9 V +1 04/01/21, 14:47 Completed build in 06m 54s on Thu, 1 Apr, 02:46 PM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10448
-
core-ci voted on patch set 9 V +1 04/01/21, 14:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1979
-
Jonas Eberle uploaded patch set 10 04/02/21, 11:04
-
Jonas Eberle commented on patch set 10 04/02/21, 11:06
A discussion revealed that it is not safe to D-I LanguageService. This now uses ->sL of either TSFE or LANG, depending on what is available (with priority to TSFE). -
TYPO3com voted on patch set 10 V +1 04/02/21, 11:11 Completed build in 07m 16s on Fri, 2 Apr, 11:11 AM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10460
-
core-ci voted on patch set 10 V +1 04/02/21, 11:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1994
-
Guido Schmechel voted on patch set 10 V +1 CR +1 04/02/21, 16:00
-
Riccardo De Contardi commented on patch set 10 04/02/21, 22:02
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:13I think this is "it" -
Martin Kutschker uploaded patch set 11 04/03/21, 09:53
-
TYPO3com voted on patch set 11 V +1 04/03/21, 09:58 Completed build in 05m 20s on Sat, 3 Apr, 09:58 AM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10475
-
core-ci voted on patch set 11 V +1 04/03/21, 10:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2012
-
Martin Kutschker commented on patch set 10 04/03/21, 10:55
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:13Reply"she", referring ti the user not the screen reader, is used instead of "he" to add some gender variety. -
Jonas Eberle uploaded patch set 12 04/03/21, 11:29
-
TYPO3com voted on patch set 12 V +1 04/03/21, 11:36 Completed build in 06m 35s on Sat, 3 Apr, 11:35 AM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10476
-
core-ci voted on patch set 12 V +1 04/03/21, 11:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2013
-
Jonas Eberle voted on patch set 12 V +1 CR +1 04/03/21, 11:41
-
Martin Kutschker rebased onto patch set 13 04/03/21, 14:12
-
TYPO3com voted on patch set 13 V +1 04/03/21, 14:19 Completed build in 06m 52s on Sat, 3 Apr, 02:19 PM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10477
-
core-ci voted on patch set 13 V +1 04/03/21, 14:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2014
-
Jonas Eberle voted on patch set 13 V +1 CR +1 04/03/21, 20:13
-
Torben Hansen voted on patch set 13 V +1 CR +1 04/04/21, 05:53
-
Richard Haeser commented on patch set 13 04/06/21, 08:19
YouTubeRenderer.php:221So basically, I can not deactivate this prefix if I really don't want it? Or is it a requirement for accessibility? -
Martin Kutschker commented on patch set 13 04/06/21, 11:34
YouTubeRenderer.php:221ReplyThe prefix: no, the title attribute: yes. If the title of the video makes clear that it is shown in which player you won't need the prefix. But this is IMHO rather unlikely. The prefix is worded so that it can stand on it's own. I have assumed that this is possible in all languages. If not we need more labels: one for the prefix and one for the fallback if the title is empty. -
Richard Haeser commented on patch set 13 04/06/21, 12:32
YouTubeRenderer.php:221ReplyWell, not sure if we should force people to have a prefix if it is not necessary for accessibility reasons. I think I would opt for having the option to disable it by setting an empty string. If it is not set, the default could be used. For sure, by default we should add this, but if we don't have a "must-have" reason, IMHO we should make it possible to disable it to prevent discussions and "hacks". To have an easy way to fix the translation issue, you can use sprintf with a %s in the translation so it can be different on every language if it is a prefix or a suffix. -
Martin Kutschker commented on patch set 13 04/06/21, 18:38
YouTubeRenderer.php:221ReplyUsing %s is a good idea. But what I meant is that if the video ha no name then the prefix/suffix should still make sense. Works well in English and German. But we can try to start out with the simpe solution and improve later when we get feedback from users of other languages (who care about a11y and thoroughly test their sites). -
Jonas Eberle commented on patch set 13 04/07/21, 08:34
We could add the default configuration here https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/ext_localconf.php#L68 so it is easier as an integrator to see what is used and easier for us to react for when it is set to empty. -
Martin Kutschker commented on patch set 13 04/07/21, 11:47
Reply
What why? I don't get it. Unsetting the prefix is stupid anyway. Rant: I don't get the fuss about the prefix. The title attribute of an IFRAME is AFAIK only presented to a screen reader. The defaults are reasonable and will work without any changes by the integtrator. I'm fine with allowing to make the accessibility worse by removing the prefix. But what I am not going to do is adding tiny config features bit by bit to implement ideas that IMHO no-one needs. I had multiple chances for a +2 if new ideas hadn't come up. -
Jonas Eberle commented on patch set 13 04/07/21, 12:04
I just wanted to take Richard's comment into account. It would clean up the code by splitting off the default configuration IMHO, too. But I am fine with how it is now, too. -
Richard Haeser commented on patch set 13 04/07/21, 12:13
Reply
Martin, Relax, no reason to stress ;-) I didn't do a negative vote because it is/was just a question. I asked several times if this is needed for accessibility. But I didn't got a clear answer. From this answer I get that this is necessary for accessibility reasons and if we do not mention that it is a YouTube or Vimeo video, we are not compliant. If that is the case, it is a no-brainer. IMHO we should not deliver code that is not compliant. Why I asked is because I have had the same with SEO. Although some things are best practice and most of times even proven techniques, a lot of people just want to do it wrong and disable stuff. And yes, I think that is stupid as well. To prevent discussions afterwards, I wanted to know if this is a "hard" criterium because in that case it is quite easy to "defend". It is one of our duties as core-mergers to check if a patch will not cause trouble for people. And for sure this is a really small change and most people won't even see this change, but that doesn't mean that we should easily merge things. I always want to know the why of a patch before I give a +2. Sorry if that will take some time sometimes. And for sure, I'm not the expert on this topic. So if you say it is necessary, I believe you and it is fine to merge. I just didn't got a clear answer IMHO. -
Martin Kutschker commented on patch set 13 04/07/21, 13:39
Reply
Perhaps you can explain it to me in a PM. I think I don't understand what you propose.Reply
Just a quick answer til evening. Sorry for getting upset. For me this was a seemingly simple patch that took much more time to develop than expected. Of course we should try to deliver the best experience for every our users. And so I agree that an option to disable the prefix is sane. It's not my site, so I'm happy to allow a different configuration. Sorry, for not fully making clear what is and what is not required for accessibility: in short, any title will do just like alt. But empty title is not allowed, so the prefix doubles as minimum title if the video has no name. -
Martin Kutschker uploaded patch set 14 04/10/21, 15:55
-
TYPO3com voted on patch set 14 V +1 04/10/21, 16:01 Completed build in 06m 15s on Sat, 10 Apr, 04:01 PM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10598
-
core-ci voted on patch set 14 V +1 04/10/21, 16:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2168
-
Jonas Eberle uploaded patch set 15 04/11/21, 11:22
-
TYPO3com voted on patch set 15 V +1 04/11/21, 11:28 Completed build in 06m 14s on Sun, 11 Apr, 11:28 AM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10599
-
Jonas Eberle commented on patch set 15 04/11/21, 11:28
The last patch makes use of ?? instead of "isset(...) && ...". It puts the default configuration value always into TypoScript to make the option obvious. -
core-ci voted on patch set 15 V +1 04/11/21, 11:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2172
-
Martin Kutschker commented on patch set 15 04/11/21, 15:53
VimeoRenderer.php:214You have changed the behaviour. If you set the hint to an empty string not even the video name is used title attribute. From an a11y perspective this is unfortunate. But what the heck. The default is good and if you want to screw it up, just do so. Sidenote: This does not throw errors or notices when $STFE is not defined? If so ?? does more magic I was aware of.YouTubeRenderer.php:221ReplyDone -
Jonas Eberle commented on patch set 15 04/13/21, 17:52
VimeoRenderer.php:214Reply UnresolvedI think the behaviour change is reasonable and in line with the .rst. In order to hide the hint but keep the title, you'ld use "%s". ?? is safe to use here IMHO - It works well with class members, arrays and unassigned variables (not with functions, though…). -
Jonas Eberle commented on patch set 15 06/09/21, 19:26
Reply
DoneReply
DoneHi all, I have cleaned up the status=unresolved comments a bit. Please check the open ones. @Torben The patch is not using GLOBALS[LANG] any more if it is not available. Could you please retest?Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:13ReplyDone -
Markus Klein commented on patch set 15 06/14/21, 09:10
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:19uh... having this as a top-level config option seems a bit wrong to me. This is a very specific thing. We need a new config option for every additional provider. I think this is better situated in some other place. Maybe even hardcoded in the provider itself?
-
Jonas Eberle commented on patch set 15 08/03/21, 13:40
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:19ReplyI think we are going in circles. What would you think about just an .xlf key (we provide "YouTube video %s", integrator can set "%s" if wanted). And yes, this is of course provider specific. -
Markus Klein commented on patch set 15 08/09/21, 13:16
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:19ReplyI suggest using XLF references exclusively here and avoiding TypoScript. We should use the $options array to pass in the label-id if one intends to override the default label. This can be done then transparently even via the media-viewhelper, which has the additionalArguments option. -
Jonas Eberle commented on patch set 15 08/09/21, 14:39
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:19ReplyI am not sure $options is obvious enough to be useful without explicit ViewHelper argument. I can't currently see a way that is ok with all reviewers' requests. As an integrator I would be ok with a hardcoded .xlf key ("YouTube video %s") which I can override in the usual ways with `locallangXMLOverride` or via TypoScript `_LOCAL_LANG`. -
Markus Klein commented on patch set 15 08/09/21, 19:44
Feature-93610-AddVideoPlatformNameToIframeTitleForYouTubeAndVimeo.rst:19Reply Unresolved> I can't currently see a way that is ok with all reviewers' requests. Maybe I missed something then, what requirement contradicts an XLF solution? Besides that, how often would someone realistically really change this title to something else? > As an integrator I would be ok with a hardcoded .xlf key That would probably be totally enough. My suggestion was more based on my thought "how can I adjust, without using a locallangXMLOverride?", which is probably a bit overdone. -
Jonas Eberle uploaded patch set 16 09/14/21, 20:30
-
Jonas Eberle commented on patch set 16 09/14/21, 20:41
Just rebased. I would be for a simple solution with just hard-coded .xlf keys `LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:vimeoVideoHint` `LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:youtubeVideoHint` with string "YouTube video %s". The %s will be replaced with the video title. Can we please get some feedback from earlier commenters/reviewers if that is acceptable? -
core-ci voted on patch set 16 V +1 09/14/21, 20:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16723
-
Martin Kutschker commented on patch set 16 09/15/21, 07:27
Reply Unresolved
Oliver wanted it to be configurable in the front end. The trouble is IMHO that the render is so deeply hidden with the API layers that is not easily be configured. Perhaps it is possible to pass on labels or label keys from the FE (ie Fluid view helper) down to the renderer. -
Benni Mack wrote 11/29/21, 10:09
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 17 11/29/21, 13:28
-
core-ci voted on patch set 17 V +1 11/29/21, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20033
-
Simon Schaufelberger uploaded patch set 18 03/22/22, 23:38
-
core-ci voted on patch set 18 V +1 03/22/22, 23:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25064
-
Torben Hansen wrote 04/24/23, 11:12
Removed reviewer Torben Hansen. -
Simon Schaufelberger uploaded patch set 19
V +108/21/23, 20:19 -
core-ci voted on patch set 19 V -1 08/21/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45655
-
Simon Schaufelberger uploaded patch set 20
V -108/22/23, 09:08 -
core-ci voted on patch set 20 V +1 08/22/23, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45665
-
Garvin Hicking wrote 01/07/25, 23:19
Topic 68148 removed -
Benni Mack uploaded patch set 21
V +103/28/25, 12:04 -
Benni Mack commented on patch set 21 03/28/25, 12:04
I rebased the patch into a "working state" but there are references to $GLOBALS[TSFE] and TypOScript, which do not exist anymore. I will move this to WIP for the tim being, until somebody wants to continue here... tests are green though :) -
Benni Mack marked it work in progress 03/28/25, 12:04
-
core-ci voted on patch set 21 V -1 03/28/25, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76577
-
Simon Schaufelberger uploaded patch set 22
V -103/08/26, 19:55 -
core-ci voted on patch set 22 V -1 03/08/26, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97574