Review main Merged

68166[TASK] Add test for writing webp files via IM/GM to environment checker

Benni Mack CR +2 V +2 Normal +73 −4 updated 03/02/21, 19:01

Commit message

This change adds test images for checking if the installed IM/GM version
can create webp images.

Similar to the pdf/ai files tests, these changes are allowed to
fail, and - if the browser does not support
webp (https://caniuse.com/webp) - will not show up either.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Daniel Sattler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Daniel Sattler +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 1218

  1. Benni Mack uploaded patch set 1 03/02/21, 15:19

  2. TYPO3com voted on patch set 1 V +1 03/02/21, 15:28 Completed build in 09m 06s on Tue, 2 Mar, 03:28 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9808

  3. Daniel Sattler voted on patch set 1 V +1 CR +1 03/02/21, 15:29

  4. core-ci voted on patch set 1 V +1 03/02/21, 15:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1123

  5. Benni Mack uploaded patch set 2 03/02/21, 17:00

  6. Daniel Sattler voted on patch set 2 V +1 CR +1 03/02/21, 17:06

  7. TYPO3com voted on patch set 2 V +1 03/02/21, 17:07 Completed build in 07m 18s on Tue, 2 Mar, 05:07 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9809

  8. core-ci voted on patch set 2 V +1 03/02/21, 17:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1124

  9. Oli Bartsch commented on patch set 2 V +1 03/02/21, 17:15

    GraphicalFunctions.php:113

    Just wondering, since this should not be needed for the install tool test.
  10. Christian Kuhn commented on patch set 2 03/02/21, 17:50

    GraphicalFunctions.php:113 Reply

    but it's ok, right?
  11. Christian Kuhn commented on patch set 3 03/02/21, 17:53

    Published edit on patch set 2.
  12. Christian Kuhn voted on patch set 3 V +1 CR +1 03/02/21, 17:54

  13. Daniel Sattler voted on patch set 3 V +1 CR +1 03/02/21, 17:56

  14. TYPO3com voted on patch set 3 V +1 03/02/21, 18:00 Completed build in 07m 03s on Tue, 2 Mar, 06:00 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9811

  15. core-ci voted on patch set 3 V +1 03/02/21, 18:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1127

  16. Benni Mack commented on patch set 3 03/02/21, 19:01

    GraphicalFunctions.php:113 Reply

    yes. this list is actually overridden all the time when instantiating GifBuilder/GraphicalFunctions by using TYPO3_CONF_VARS, and in the installer explicitly sets this.
  17. Benni Mack voted on patch set 3 V +2 CR +2 03/02/21, 19:01

  18. Benni Mack merged patch set 4 03/02/21, 19:01