68166[TASK] Add test for writing webp files via IM/GM to environment checker
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Daniel Sattler +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Daniel Sattler +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php3+1 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+66 −1
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+6 −2
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.webpnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Convert-webp.webpnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Write-webp.webpnewbinary
Review log 1218
-
Benni Mack uploaded patch set 1 03/02/21, 15:19
-
TYPO3com voted on patch set 1 V +1 03/02/21, 15:28 Completed build in 09m 06s on Tue, 2 Mar, 03:28 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9808
-
Daniel Sattler voted on patch set 1 V +1 CR +1 03/02/21, 15:29
-
core-ci voted on patch set 1 V +1 03/02/21, 15:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1123
-
Benni Mack uploaded patch set 2 03/02/21, 17:00
-
Daniel Sattler voted on patch set 2 V +1 CR +1 03/02/21, 17:06
-
TYPO3com voted on patch set 2 V +1 03/02/21, 17:07 Completed build in 07m 18s on Tue, 2 Mar, 05:07 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9809
-
core-ci voted on patch set 2 V +1 03/02/21, 17:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1124
-
Oli Bartsch commented on patch set 2 V +1 03/02/21, 17:15
-
Christian Kuhn commented on patch set 2 03/02/21, 17:50
GraphicalFunctions.php:113Replybut it's ok, right? -
Christian Kuhn commented on patch set 3 03/02/21, 17:53
Published edit on patch set 2. -
Christian Kuhn voted on patch set 3 V +1 CR +1 03/02/21, 17:54
-
Daniel Sattler voted on patch set 3 V +1 CR +1 03/02/21, 17:56
-
TYPO3com voted on patch set 3 V +1 03/02/21, 18:00 Completed build in 07m 03s on Tue, 2 Mar, 06:00 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9811
-
core-ci voted on patch set 3 V +1 03/02/21, 18:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1127
-
Benni Mack commented on patch set 3 03/02/21, 19:01
GraphicalFunctions.php:113Replyyes. this list is actually overridden all the time when instantiating GifBuilder/GraphicalFunctions by using TYPO3_CONF_VARS, and in the installer explicitly sets this. -
Benni Mack voted on patch set 3 V +2 CR +2 03/02/21, 19:01
-
Benni Mack merged patch set 4 03/02/21, 19:01
GraphicalFunctions.php:113