Review main Merged

68170[BUGFIX] Inject Logger into LanguagePackService

Martin Kutschker CR +2 V +2 Easy +16 −8 updated 03/03/21, 09:15

Commit message

The EXT:install ServiceProvider introduced in #89892 didn't respect
that LanguagePackService implements LoggerAwareInterface. That means
the logger variable was null and usages of the logger resulted in
exceptions.

Refactor the class to require the logger instance to always be
injected via constructor injection, to prevent this from happening
again.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2