Review main Merged

68197[FEATURE] Add Symfony mailer DSN configuration option to install tool

Markus Hölzle CR +2 V +2 Normal +85 −1 updated 05/06/21, 11:22

Commit message

The install tool has now the possibility to configure
the Symfony mailer with DSN.

The DSN setting was already implemented but with a not
consistent configuration option and was never documented.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2434

Show 59 earlier messages
  1. Markus Hölzle uploaded patch set 1 03/06/21, 09:43

  2. TYPO3com voted on patch set 1 V +1 03/06/21, 09:49 Completed build in 06m 19s on Sat, 6 Mar, 09:49 AM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9876

  3. core-ci voted on patch set 1 V +1 03/06/21, 09:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1212

  4. Guido Schmechel commented on patch set 1 03/06/21, 10:21

    Can we please add a test in typo3\sysext\core\Tests\Unit\Mail\TransportFactoryTest.php? You can orient yourself at getThrowsRuntimeExceptionForInvalidCustomSpool()
  5. Benni Mack commented on patch set 1 03/06/21, 11:11

    Sounds like a good "feature"?
  6. Markus Hölzle uploaded patch set 2 03/06/21, 13:22

  7. Markus Hölzle commented on patch set 2 03/06/21, 13:27

    Should we rename $GLOBALS['TYPO3_CONF_VARS']['MAIL']['dsn'] to $GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport_dsn'] ?
  8. TYPO3com voted on patch set 2 V +1 03/06/21, 13:29 Completed build in 06m 15s on Sat, 6 Mar, 01:29 PM Test Summary: 32749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9877

  9. core-ci voted on patch set 2 V +1 03/06/21, 13:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1214

  1. Benni Mack commented on patch set 2 03/16/21, 20:34

    Reply

    Yeah, let's do that!
  2. Benni Mack commented on patch set 2 CR +1 03/22/21, 18:40

    Reply

    let's keep it "dsn" as it was named like that before.
  3. Benni Mack uploaded patch set 3 03/22/21, 18:42

  4. TYPO3com voted on patch set 3 V +1 03/22/21, 18:49 Completed build in 06m 58s on Mon, 22 Mar, 06:49 PM Test Summary: 32911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10292

  5. core-ci voted on patch set 3 V +1 03/22/21, 18:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1766

  6. Simon Gilli voted on patch set 3 CR +1 04/27/21, 19:31

  7. Benjamin Franzke voted on patch set 3 V +1 CR +1 04/30/21, 10:02

  8. Guido Schmechel voted on patch set 3 V +1 CR +1 05/01/21, 10:15

  9. Christian Kuhn commented on patch set 3 CR -1 05/03/21, 10:51

    really think an example in the .rst file would be great. sorry for -1 due to this little detail.

    Feature-93668-PossibilityToConfigureSymfonyMailer.rst:20

    it would be great to have one or two examples for valid DSN's here - i suppose not everyone is familiar with the abbreviation, so seeing an example in addition to the symfony help link could be useful.
  10. Simon Gilli commented on patch set 4 05/04/21, 10:04

    Published edit on patch set 3.
  11. core-ci voted on patch set 4 V +1 05/04/21, 10:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11092

  12. Simon Gilli commented on patch set 5 05/04/21, 10:18

    Published edit on patch set 4.
  13. Simon Gilli commented on patch set 5 V +1 CR +1 05/04/21, 10:19

    Feature-93668-PossibilityToConfigureSymfonyMailer.rst:20 Reply

    done
  14. core-ci voted on patch set 5 V +1 05/04/21, 10:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11093

  15. Guido Schmechel voted on patch set 5 V +1 CR +1 05/04/21, 11:17

  16. Benjamin Franzke commented on patch set 5 CR -1 05/04/21, 11:29

    Sorry to intercept, but we should improve the headline of this commit message. I mean a) we already have the possibility to configure symfony mailer, in general… b) We use imperative in commit msgs, sth like "Add possibility" c) This really is just about the DSN Maybe "Add Symfony mailer DSN configuration option to install tool".

    Feature-93668-PossibilityToConfigureSymfonyMailer.rst:36

    Hm, rethinking this: It seems to actually be a breaking change. Can we add a (silent) migration update?
  17. Simon Gilli commented on patch set 6 05/05/21, 14:26

    Published edit on patch set 5.
  18. Simon Gilli updated the commit message in patch set 7 05/05/21, 14:27

  19. Simon Gilli commented on patch set 7 05/05/21, 14:28

    Reply

    Done

    Feature-93668-PossibilityToConfigureSymfonyMailer.rst:36 Reply

    Done
  20. core-ci voted on patch set 6 V +1 05/05/21, 14:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11218

  21. core-ci voted on patch set 7 V +1 05/05/21, 14:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11219

  22. Simon Gilli voted on patch set 7 V +1 CR +1 05/05/21, 14:43

  23. Guido Schmechel voted on patch set 7 V +1 CR +1 05/05/21, 14:56

  24. Benjamin Franzke voted on patch set 7 V +2 CR +2 05/06/21, 11:22

  25. Benjamin Franzke merged patch set 8 05/06/21, 11:22