Review main Merged

68232[TASK] Update to typo3/cms-styleguide:~11.1.0

Christian Kuhn CR +2 V +2 Normal +51 −50 updated 03/08/21, 10:18

Commit message

composer req --dev typo3/cms-styleguide:~11.1.0

New version brings a series of field label changes. The
FormEngine acceptance tests need a slight xpath adaption
to deal with this, which also stabilizes the selectors a bit.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 7

Review log 1121

  1. Christian Kuhn uploaded patch set 1 03/07/21, 13:33

  2. TYPO3com voted on patch set 1 V -1 03/07/21, 13:45 Completed build in 11m 57s on Sun, 7 Mar, 01:45 PM Test Summary: 3 of 32987 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9900

  3. core-ci voted on patch set 1 V -1 03/07/21, 13:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1242

  4. Christian Kuhn uploaded patch set 2 03/07/21, 16:00

  5. TYPO3com voted on patch set 2 V -1 03/07/21, 16:07 Completed build in 06m 41s on Sun, 7 Mar, 04:07 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9901

  6. core-ci voted on patch set 2 V -1 03/07/21, 16:10 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1243

  7. Christian Kuhn uploaded patch set 3 03/07/21, 16:17

  8. Christian Kuhn updated the commit message in patch set 4 03/07/21, 16:20

  9. TYPO3com voted on patch set 3 V +1 03/07/21, 16:24 Completed build in 07m 12s on Sun, 7 Mar, 04:24 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9902

  10. core-ci voted on patch set 3 V +1 03/07/21, 16:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1244

  11. TYPO3com voted on patch set 4 V +1 03/07/21, 16:29 Completed build in 09m 17s on Sun, 7 Mar, 04:29 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9903

  12. core-ci voted on patch set 4 V +1 03/07/21, 16:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1245

  13. Lina Wolf commented on patch set 4 CR +1 03/07/21, 17:13

    Good idea
  14. Oli Bartsch voted on patch set 4 V +1 CR +1 03/08/21, 08:24

  15. Richard Haeser updated the commit message in patch set 5 03/08/21, 10:01

  16. Richard Haeser voted on patch set 5 V +1 CR +1 03/08/21, 10:01

  17. TYPO3com voted on patch set 5 V +1 03/08/21, 10:07 Completed build in 06m 25s on Mon, 8 Mar, 10:07 AM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9918

  18. core-ci voted on patch set 5 V +1 03/08/21, 10:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1263

  19. Oli Bartsch voted on patch set 5 V +1 CR +1 03/08/21, 10:18

  20. Richard Haeser voted on patch set 5 V +2 CR +2 03/08/21, 10:18

  21. Richard Haeser merged patch set 6 03/08/21, 10:18