Review main Merged

68254[BUGFIX] Avoid loading console commands before container is current

Benjamin Franzke CR +2 V +2 Easy +28 −11 updated 03/10/21, 10:01

Commit message

The shortcut handling added in #86248 caused the matching command
to be loaded before the symfony DI container was made available to
GeneralUtility::makeInstance (FailsafeContainer was still active).
This caused services (e.g in #93442) that are instantiated using the
GeneralUtility::makeInstance-to-DI-Container bridge to fail
as these services are not available in the FailsafeContainer.

Background: the symfony Application:find() method did not just
search for a matching command, but it also initialized it, once found.
Therefore shortcut resolving is now handled within the TYPO3 command
application to ensure commands are only instantiated once the
symfony container (and localconf) is fully loaded.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1