6830[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Tolleiv Nietsch +1
- Dmitry Dulepov +1
-
Verified V +2
- Susi Moog +2
- Tolleiv Nietsch +1
Files 1
Review log 20
-
Susi Moog merged patch set 1 02/28/12, 21:04
-
Tolleiv Nietsch uploaded patch set 4 02/28/12, 21:04
-
Tolleiv Nietsch commented on patch set 4 02/28/12, 21:04
Verified; Looks good to me, but someone else must approve there was still a path left where $domain could remain empty (domain record without 'domainName' - besides that the patch worked fine -
Markus Klein commented on patch set 3 02/28/12, 21:04
Integrated into current master. -
Markus Klein uploaded patch set 3 02/28/12, 21:04
-
Tolleiv Nietsch commented on patch set 5 02/28/12, 21:04
Verified; Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 5 02/28/12, 21:04
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 5 02/28/12, 21:04
-
Susi Moog commented on patch set 5 V 0 02/28/12, 21:04
by team member; Looks good to me, approved -
Oliver Hader uploaded patch set 2 02/28/12, 21:04
-
Oliver Hader commented on patch set 2 02/28/12, 21:04
Rebasing to master V:0, R:0 -
Georg Ringer commented on patch set 4 02/28/12, 21:04
(1 inline comment)class.t3lib_befunc.php:26361) $protocol is maybe undefined as it is only defined in the if(count() > 0) 2) is this a good idea to have $domain = $protocol . '://' . $domain; => 2 lines before AND return $protocol . $domain; wouldn't that mean, just from reading: return $protocol . $protocol . $domain ? -
Mr. Jenkins commented on patch set 1 02/28/12, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2462/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/28/12, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2665/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/28/12, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2784/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/28/12, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2972/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/28/12, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2979/ : SUCCESS -
Jaume Prat commented on patch set 3 02/28/12, 21:04
Verified; Looks good to me, but someone else must approve -
Jaume Prat commented on patch set 4 02/28/12, 21:04
Verified; Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 5 02/28/12, 21:04
Does not work if no domain record is set - please have a look to issue #34396 before creating cherry-picks to older branches.