Review main Merged

6830[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain

Xavier Perseguers CR +2 V +2 Easy +13 −9 updated 06/03/13, 20:49

Commit message

If the TYPO3 BE host name is not configured as a sys_domain record
t3lib_BEfunc::getViewDomain() will always return TYPO3 BE host name
and not the first domain of the root line of the page which is
being previewed.

Furthermore, if the TYPO3 BE host name is configured as a sys_domain
but the current root line does not contain a valid domain record,
t3lib_BEfunc::getViewDomain() will return only 'http://' ie. no domain.

Review

  • Code review CR +2
    • Susi Moog +2
    • Tolleiv Nietsch +1
    • Dmitry Dulepov +1
  • Verified V +2
    • Susi Moog +2
    • Tolleiv Nietsch +1

Files 1

Review log 20

  1. Susi Moog merged patch set 1 02/28/12, 21:04

  2. Tolleiv Nietsch uploaded patch set 4 02/28/12, 21:04

  3. Tolleiv Nietsch commented on patch set 4 02/28/12, 21:04

    Verified; Looks good to me, but someone else must approve there was still a path left where $domain could remain empty (domain record without 'domainName' - besides that the patch worked fine
  4. Markus Klein commented on patch set 3 02/28/12, 21:04

    Integrated into current master.
  5. Markus Klein uploaded patch set 3 02/28/12, 21:04

  6. Tolleiv Nietsch commented on patch set 5 02/28/12, 21:04

    Verified; Looks good to me, but someone else must approve
  7. Dmitry Dulepov commented on patch set 5 02/28/12, 21:04

    Looks good to me, but someone else must approve
  8. Markus Klein uploaded patch set 5 02/28/12, 21:04

  9. Susi Moog commented on patch set 5 V 0 02/28/12, 21:04

    by team member; Looks good to me, approved
  10. Oliver Hader uploaded patch set 2 02/28/12, 21:04

  11. Oliver Hader commented on patch set 2 02/28/12, 21:04

    Rebasing to master V:0, R:0
  12. Georg Ringer commented on patch set 4 02/28/12, 21:04

    (1 inline comment)

    class.t3lib_befunc.php:2636

    1) $protocol is maybe undefined as it is only defined in the if(count() > 0) 2) is this a good idea to have $domain = $protocol . '://' . $domain; => 2 lines before AND return $protocol . $domain; wouldn't that mean, just from reading: return $protocol . $protocol . $domain ?
  13. Mr. Jenkins commented on patch set 1 02/28/12, 21:04

  14. Mr. Jenkins commented on patch set 2 02/28/12, 21:04

  15. Mr. Jenkins commented on patch set 3 02/28/12, 21:04

  16. Mr. Jenkins commented on patch set 4 02/28/12, 21:04

  17. Mr. Jenkins commented on patch set 5 02/28/12, 21:04

  18. Jaume Prat commented on patch set 3 02/28/12, 21:04

    Verified; Looks good to me, but someone else must approve
  19. Jaume Prat commented on patch set 4 02/28/12, 21:04

    Verified; Looks good to me, but someone else must approve
  20. Oliver Hader commented on patch set 5 02/28/12, 21:04

    Does not work if no domain record is set - please have a look to issue #34396 before creating cherry-picks to older branches.