Review main Merged

68302[BUGFIX] Adjust tab menu styling

Oli Bartsch CR +2 V +2 Easy +19 −22 updated 03/11/21, 16:25

Commit message

Because bootstrap 5 requires the `.nav-link` class for styling
of nav tab links, our custom SCSS now uses the class selector
together with the type selector. Otherwise it will be overruled
by the default bootstrap styles because of their specificity.

See: https://getbootstrap.com/docs/5.0/components/navs-tabs/#fill-and-justify

Furthermore is the `.active` class, indicating the active tab,
not longer set on the `.nav-item` element, but on the `.nav-link`
element. The custom SCSS is therefore adjusted to respect this
changed behaviour.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2