Review main Merged

68303[TASK] Separate concerns in SVGTree implementations

Benni Mack CR +2 V +2 Hard +449 −494 updated 03/10/21, 11:05

Commit message

This patch provides the following changes in order to
have better abstractions and encapsulate the dependencies
of each implementation.

1. SelectTree (Category Tree)

The TreeToolbar is now clearly coupled into the SelectTree
and built as LitElement inside the SelectTreeElement.

SelectTree now contains all relevant functionality
regarding selecting multiple items, and shows settings
(SelectTreeSettings) which were only used in SelectTree.

This is especially relevant for the multiple item selection,
and the exclusiveKey handling.

2. PageTree + FileStorageTree
Obsolete public methods are removed, and visibility is changed.
Filtering is now separated in favor of a non-public property.
By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted
Obsolete wrapper methods are removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16