Review main Merged

68308[TASK] Add example to SYS|reverseProxyPrefix config

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/10/21, 19:33

Commit message

The example is taken from the actual code comment.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1218

  1. Markus Klein uploaded patch set 1 03/10/21, 13:25

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 13:37 Completed build in 11m 42s on Wed, 10 Mar, 01:37 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10013

  3. core-ci voted on patch set 1 V +1 03/10/21, 13:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1371

  4. Benjamin Franzke commented on patch set 1 CR -1 03/10/21, 13:42

    DefaultConfigurationDescription.yaml:149 Unresolved

    I think this is mistakable. While the code comment in typo3/sysext/core/Classes/Http/NormalizedParams.php makes clear that the settings is uses for mapping scenarios ext-domain.com to int-server.com/prefix, this description in this context reads as if a value like 'ext-domain.com => int-server.com/prefix' should be set.
  5. Markus Klein uploaded patch set 2 03/10/21, 14:44

  6. core-ci voted on patch set 2 V +1 03/10/21, 14:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1375

  7. TYPO3com voted on patch set 2 V +1 03/10/21, 14:56 Completed build in 12m 17s on Wed, 10 Mar, 02:56 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10017

  8. Josef Glatz commented on patch set 2 03/10/21, 15:08

    I really like the new info in the description!! Thanks Markus.
  9. Benni Mack voted on patch set 2 V +2 CR +2 03/10/21, 15:59

  10. Benni Mack voted on patch set 2 V +1 CR +1 03/10/21, 15:59

  11. Ernesto Baschny commented on patch set 2 03/10/21, 16:08

    DefaultConfigurationDescription.yaml:149

    The description seem to be "HTML", which means we should probably avoid having ">" or "<" literally in the content.
  12. Markus Klein commented on patch set 2 03/10/21, 16:13

    DefaultConfigurationDescription.yaml:149 Reply

    Ack
  13. Markus Klein commented on patch set 3 03/10/21, 16:13

    Published edit on patch set 2.
  14. TYPO3com voted on patch set 3 V +1 03/10/21, 16:23 Completed build in 09m 22s on Wed, 10 Mar, 04:23 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10020

  15. core-ci voted on patch set 3 V +1 03/10/21, 16:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1378

  16. Josef Glatz voted on patch set 3 V +1 CR +1 03/10/21, 17:34

  17. Benjamin Franzke voted on patch set 3 V +2 CR +2 03/10/21, 19:33

  18. Benjamin Franzke merged patch set 4 03/10/21, 19:33