Review 10.4 Merged

68313[BUGFIX] Use Live Page ID in workspace routing

Benni Mack CR +2 V +2 Easy +6 −3 updated 03/09/21, 17:00

Commit message

When in a workspace, the slug of a workspace'd
page record is properly resolved (good!), but
the versioned ID of the page is used within
the PageArguments.

This is in turn lets TSFE think that the "Page ID"
is the versioned ID, which is wrong (similarly to
the localized page ID / translated page ID), which
always need to be the live Page ID in order to
properly handle records on the page ("pid=live/default ID of the page")

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3