Review main Merged

68332[TASK] De-duplicate Tree code for filtering

Benni Mack CR +2 V +2 Hard +170 −261 updated 03/11/21, 09:48

Commit message

This change optimizes the SVG Tree implementations (again),
this time focussing on using proper constructors for SVG
tree and its derivatives (SelectTree, PageTree, FileStorageTree).

In addition, the search + filter logic is now moved
into the base class, in order to reduce duplicate code,
and to re-add features (next steps) that were not
implemented in TYPO3 v9 when re-writing the page tree,
such as highlighting filtered results.

In addition, unused properties and settings are
removed.

This change marks one of the final changes for
reworking the SVG Tree implementation, afterwards
allowing us to move towards:
* native DOM events in favor of d3-dispatch
* custom elements instead of wrapper methods
* decouple "top." and "document." based settings into the Container classes

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14