Review main Merged

68378[BUGFIX] Correct file path in acceptance tests

Christian Kuhn CR +2 V +2 Easy +5 −4 updated 03/14/21, 15:52

Commit message

codeception seeFileFound() and dontSeeFileFound() apply
some path magic if relative files are given. It leads
to wrong paths. This is however not (yet) shown due to
error suppression in the suite.
To work on ac test error handling for increased PHP 8
compatibility, this needs to be sorted out first.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 612

  1. Christian Kuhn uploaded patch set 1 03/14/21, 14:06

  2. Christian Kuhn uploaded patch set 2 03/14/21, 14:07

  3. TYPO3com voted on patch set 2 V -1 03/14/21, 14:14 Completed build in 06m 52s on Sun, 14 Mar, 02:14 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10110

  4. TYPO3com voted on patch set 1 V +1 03/14/21, 14:15 Completed build in 09m 00s on Sun, 14 Mar, 02:15 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10109

  5. core-ci voted on patch set 1 V +1 03/14/21, 14:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1497

  6. core-ci voted on patch set 2 V -1 03/14/21, 14:26 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1498

  7. Christian Kuhn uploaded patch set 3 03/14/21, 14:30

  8. TYPO3com voted on patch set 3 V +1 03/14/21, 14:40 Completed build in 10m 08s on Sun, 14 Mar, 02:40 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10112

  9. core-ci voted on patch set 3 V +1 03/14/21, 14:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1502

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 03/14/21, 15:51

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/14/21, 15:52

  12. Anja Leichsenring merged patch set 4 03/14/21, 15:52