Review 10.4 Merged

68379[BUGFIX] Correct file path in acceptance tests

Christian Kuhn CR +2 V +2 Easy +5 −4 updated 03/14/21, 15:52

Commit message

codeception seeFileFound() and dontSeeFileFound() apply
some path magic if relative files are given. It leads
to wrong paths. This is however not (yet) shown due to
error suppression in the suite.
To work on ac test error handling for increased PHP 8
compatibility, this needs to be sorted out first.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 511

  1. Christian Kuhn uploaded patch set 1 03/14/21, 14:09

  2. TYPO3com voted on patch set 1 V -1 03/14/21, 14:20 Completed build in 10m 05s on Sun, 14 Mar, 02:20 PM Test Summary: 75483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1196

  3. core-ci voted on patch set 1 V -1 03/14/21, 14:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1499

  4. Christian Kuhn uploaded patch set 2 03/14/21, 14:29

  5. Christian Kuhn updated the commit message in patch set 3 03/14/21, 14:30

  6. TYPO3com voted on patch set 2 V +1 03/14/21, 14:40 Completed build in 10m 36s on Sun, 14 Mar, 02:40 PM Test Summary: 75483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1197

  7. core-ci voted on patch set 2 V +1 03/14/21, 14:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1501

  8. TYPO3com voted on patch set 3 V +1 03/14/21, 14:42 Completed build in 11m 47s on Sun, 14 Mar, 02:42 PM Test Summary: 75483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1198

  9. core-ci voted on patch set 3 V +1 03/14/21, 14:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1503

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/14/21, 15:52

  11. Anja Leichsenring merged patch set 4 03/14/21, 15:52