Review main Merged

68462[TASK] Add information about SMTP and port 465 to Install Tool

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/16/21, 15:11

Commit message

If port 465 is used for SMTP the `transport_smtp_encrypt` feature is
automatically enabled by the underlying symfony component.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 612

  1. Markus Klein uploaded patch set 1 03/16/21, 10:54

  2. core-ci voted on patch set 1 V -1 03/16/21, 11:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1596

  3. TYPO3com voted on patch set 1 V -1 03/16/21, 11:10 Completed build in 16m 02s on Tue, 16 Mar, 11:10 AM Test Summary: 27805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10159

  4. Christian Kuhn rebased onto patch set 2 03/16/21, 13:59

  5. TYPO3com voted on patch set 2 V -1 03/16/21, 14:06 Completed build in 07m 05s on Tue, 16 Mar, 02:06 PM Test Summary: 32083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10164

  6. core-ci voted on patch set 2 V +1 03/16/21, 14:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1601

  7. TYPO3com commented on patch set 2 03/16/21, 14:17 Completed build in 24m 41s on Tue, 16 Mar, 02:17 PM Test Summary: 32479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10164

  8. TYPO3com voted on patch set 2 V +1 03/16/21, 14:19 Completed build in 44m 43s on Tue, 16 Mar, 02:19 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10164

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 03/16/21, 14:20

  10. Markus Timtner commented on patch set 2 03/16/21, 15:04

    Nice find! Thank you.
  11. Benjamin Franzke voted on patch set 2 V +2 CR +2 03/16/21, 15:10

  12. Benjamin Franzke merged patch set 3 03/16/21, 15:11