Review main Merged

68464[TASK] Use native DOM events instead of d3

Benni Mack CR +2 V +2 Hard +375 −396 updated 06/05/21, 14:41

Commit message

This change reduces the overhead of the d3 framework
by using native CustomEvents on the actual Lit element
of the SVG instead of d3-dispatch logic:

* typo3:svg-tree:nodes-prepared (enrich node data)
* typo3:svg-tree:expand-toggle (expand/collapse)
* typo3:svg-tree:node-context (clickmenu)
* typo3:svg-tree:node-selected (on-click)

As shown in the patch, the actual logic of interacting
with the outside framework (Persistent, ContextMenu, window.)
is moved to the actual Lit components, making the SVG
tree slimmer and easier to maintain.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14