Review main Merged

68466[TASK] Use PHP class name resolution over strings

Oli Bartsch CR +2 V +2 Easy +6 −6 updated 03/16/21, 19:58

Commit message

Some TCA configurations were still using strings for
class references in the itemsProcFunc option.

Since this is error-prone and also prevents proper IDE
support, all remaining places are changed to use the
automatic PHP class name resolution with ::class.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 611

  1. Oli Bartsch uploaded patch set 1 03/16/21, 17:55

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 03/16/21, 18:01

  3. TYPO3com voted on patch set 1 V +1 03/16/21, 18:03 Completed build in 07m 19s on Tue, 16 Mar, 06:03 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10169

  4. core-ci voted on patch set 1 V -1 03/16/21, 18:10 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1609

  5. Christian Kuhn rebased onto patch set 2 03/16/21, 18:27

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 03/16/21, 18:27

  7. TYPO3com voted on patch set 2 V -1 03/16/21, 18:35 Completed build in 07m 38s on Tue, 16 Mar, 06:35 PM Test Summary: 32082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10171

  8. core-ci voted on patch set 2 V +1 03/16/21, 18:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1611

  9. TYPO3com voted on patch set 2 V +1 03/16/21, 19:37 Completed build in 1h 17m 40s on Tue, 16 Mar, 07:37 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10171

  10. Georg Ringer voted on patch set 2 V +2 CR +2 03/16/21, 19:58

  11. Georg Ringer merged patch set 3 03/16/21, 19:58