68501[BUGFIX] Support SITEROOT placeholder in addRecord fieldControl
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 1016
-
Daniel Goerz uploaded patch set 1 03/18/21, 09:11
-
Daniel Goerz commented on patch set 1 03/18/21, 09:14
This feature is actually documented down to 9.5. See https://docs.typo3.org/m/typo3/reference-tca/9.5/en-us/ColumnsConfig/Type/selectMultipleSideBySide.html#addrecord. So I would be fine backporting this to fill the gap between documentation and code. -
TYPO3com voted on patch set 1 V +1 03/18/21, 09:19 Completed build in 07m 39s on Thu, 18 Mar, 09:19 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10210
-
Christian Kuhn commented on patch set 1 CR -1 03/18/21, 09:20
-1 for the moment - in general i'd like to avoid 'new' marker based placeholder in tca and would want to have a look on what is currently there. -
core-ci voted on patch set 1 V +1 03/18/21, 09:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1662
-
Christian Kuhn commented on patch set 1 03/22/21, 09:52
Feature-93770-AddRecordWizardSupportsSiterootAsPidValue.rst:4Unresolvedimho, we're fixing a bug here: the option is documented 'since ever' (at least goes back to before-v7). -
Christian Kuhn uploaded patch set 2 03/22/21, 09:56
-
Christian Kuhn updated the commit message in patch set 3 03/22/21, 09:57
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/22/21, 09:59
-
TYPO3com voted on patch set 2 V +1 03/22/21, 10:03 Completed build in 07m 01s on Mon, 22 Mar, 10:03 AM Test Summary: 32906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10276
-
TYPO3com voted on patch set 3 V +1 03/22/21, 10:04 Completed build in 06m 57s on Mon, 22 Mar, 10:04 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10277
-
core-ci voted on patch set 2 V +1 03/22/21, 10:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1748
-
core-ci voted on patch set 3 V +1 03/22/21, 10:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1749
-
Oli Bartsch voted on patch set 3 V +1 CR +1 03/22/21, 10:18
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/22/21, 10:51
-
Christian Kuhn merged patch set 4 03/22/21, 10:52