68531[TASK] Get list and dropdown of tt_content in line with records
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 913
-
Sebastian Fischer uploaded patch set 1 03/21/21, 18:29
-
TYPO3com voted on patch set 1 V +1 03/21/21, 18:37 Completed build in 07m 55s on Sun, 21 Mar, 06:37 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10267
-
core-ci voted on patch set 1 V +1 03/21/21, 18:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1734
-
Christian Kuhn commented on patch set 1 03/26/21, 10:53
hmm. Does this interfere with TCEMAIN.preview.tt_content.previewPageId, maybe? This is used for instance to store news records on some sysfolder and have the 'view' button in formengine link to some different page for frontend rendering. Maybe we should review if that tsconfig should be taken into account for tt_content click menu and list module? -
Sebastian Fischer commented on patch set 1 03/26/21, 14:11
Reply
So if i get it right, your idea is to check wether tt_content.previewPageId is set and only remove the preview button if its empty, right? -
Christian Kuhn commented on patch set 1 03/26/21, 14:16
Reply Unresolved
not 100% sure, but maybe, yes. at least we should see if this interferes with your change. -
Christian Kuhn commented on patch set 1 CR -1 03/26/21, 16:22
we'll solve that differently, Sebastian will push. -
Sebastian Fischer uploaded patch set 2 04/03/21, 06:40
-
TYPO3com voted on patch set 2 V +1 04/03/21, 06:47 Completed build in 06m 57s on Sat, 3 Apr, 06:47 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10474
-
core-ci voted on patch set 2 V +1 04/03/21, 06:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2011
-
Oli Bartsch commented on patch set 2 V -1 04/06/21, 08:26
This removes the show button for all tt_content records in recordlist. The bug report however only describes the problem of tt_content records on "now previewable" doktypes like sys_folder. For tt_content records on "previewable" pages the button makes much sense since it also contains the anchor which is really helpful for pages with a lot of content elements. So I would like to have the button not hidden for all tt_content records but only for those on "not previewable" doktypes. -
Christian Kuhn commented on patch set 2 07/19/21, 18:38
Sebastian. Even though we talked about this patch and you pushed my suggested solution, I must admit that oli's patch from https://review.typo3.org/c/Packages/TYPO3.CMS/+/69959 is better. Is that fine with you? If so, we could abandon this approach and bring in Oli's solution. -
Christian Kuhn abandoned the change 07/22/21, 15:20