Review main Merged

68559[BUGFIX] Fix SVG tree height and toolbar in TCA select-tree

Benjamin Franzke CR +2 V +2 Easy +9 −3 updated 03/23/21, 20:30

Commit message

The previos flex-basis: auto setting caused the svg to grow
from it's initial size, which may be larger than the svg
tree container height. This caused visual overflows.
Fix this by start flex-growing zero based (flex-basis = 0).

Also ensure that the toolbar stays on top of the categories
while scrolling (position: sticky) and remove an invalid
flex-direction property (the svg-tree-wrapper used
display:block, therefore flex-direction has no effect).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2