Review main Merged

68560[BUGFIX] Ensure compared values are of same type

Oli Bartsch CR +2 V +2 Easy +14 −5 updated 03/24/21, 08:43

Commit message

When strict type comparison was introduced to
the OptionViewHelper in #90540, it was not properly
ensured that the values to compare are of same type.

The issue is fixed by always typecasting the selected
value to string, before comparing it to the value in
question, which will always be a string, according to
its type hint.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2