Review main Merged

68574[TASK] Update to Twitter Bootstrap 5 beta 3

Benni Mack CR +2 V +2 Easy +10 −10 updated 03/24/21, 11:50

Commit message

This change updates the Twitter Bootstrap
dependency to version 5.0.0beta3

See https://blog.getbootstrap.com/2021/03/22/bootstrap-5-beta-3/
for more details.

Used commands:

> cd Build
> yarn upgrade bootstrap@^5.0.0-beta3
> grunt build

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 814

  1. Benni Mack uploaded patch set 1 03/23/21, 21:49

  2. TYPO3com voted on patch set 1 V -1 03/23/21, 21:49 Completed build in 17s on Tue, 23 Mar, 09:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10319

  3. Benni Mack uploaded patch set 2 03/23/21, 21:51

  4. TYPO3com voted on patch set 2 V +1 03/23/21, 21:58 Completed build in 06m 59s on Tue, 23 Mar, 09:58 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10320

  5. core-ci voted on patch set 1 V +1 03/23/21, 22:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1794

  6. core-ci voted on patch set 2 V +1 03/23/21, 22:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1795

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/24/21, 03:12

  8. Benjamin Franzke voted on patch set 2 CR +1 03/24/21, 11:04

  9. Benjamin Franzke commented on patch set 2 V -1 03/24/21, 11:06

    Live Search Dropdown is not aligned with header (2px offset)
  10. Benjamin Franzke uploaded patch set 3 03/24/21, 11:07

  11. TYPO3com voted on patch set 3 V +1 03/24/21, 11:14 Completed build in 07m 01s on Wed, 24 Mar, 11:14 AM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10325

  12. core-ci voted on patch set 3 V +1 03/24/21, 11:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1805

  13. Georg Ringer voted on patch set 3 V +2 CR +2 03/24/21, 11:50

  14. Georg Ringer merged patch set 4 03/24/21, 11:50