Review main Merged

68576[TASK] Update @types/bootstrap

Oli Bartsch CR +2 V +2 Normal +59 −22 updated 03/25/21, 14:00

Commit message

In #93810 bootstrap was updated to 5.0.0-beta3,
which contains the new "offcanvas" component.

In order to use it in TypeScript, we need to update
the corresponding type definitions.

The new type definition doo not define return types for
bootstrap JQuery methods, therefore we simply avoid
usage of these.
The update additionally revealed one bug in the login
screen, where the login-submit button did not longer
show a loading indicator as $.button('loading') is no
longer available in bootstrap 5.
This issue is fixed as a drive-by change.

Also @types/jqueryui needs to be patched as the tooltip and
button definitions conflict with those from @bootstrap/types.

Executed command:

  yarn add --dev @types/bootstrap
  yarn patch-package @types/jqueryui

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10