Review main Merged

68618[TASK] Do not restrict TCA type="text" width

Christian Kuhn CR +2 V +2 Easy +7 −5 updated 03/29/21, 05:01

Commit message

When TCA type="text" has no "cols" setting, the width of
the element is artifically restricted to some arbitrary
max width.
The patch loosens this restriction: textareas now extends
to the available width defined by an outer container.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 713

  1. Christian Kuhn uploaded patch set 1 03/26/21, 15:39

  2. Christian Kuhn updated the commit message in patch set 2 03/26/21, 15:40

  3. Christian Kuhn commented on patch set 2 03/26/21, 15:42

    see styleguide -> elements basic -> 'text' tab for before/after - most core 'type=text' fields have a 'cols' setting.
  4. TYPO3com voted on patch set 1 V +1 03/26/21, 15:45 Completed build in 05m 51s on Fri, 26 Mar, 03:45 PM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10365

  5. TYPO3com voted on patch set 2 V +1 03/26/21, 15:48 Completed build in 07m 30s on Fri, 26 Mar, 03:48 PM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10366

  6. core-ci voted on patch set 1 V +1 03/26/21, 15:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1860

  7. core-ci voted on patch set 2 V +1 03/26/21, 15:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1861

  8. Oli Bartsch uploaded patch set 3 03/26/21, 19:10

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 03/26/21, 19:10

  10. TYPO3com voted on patch set 3 V +1 03/26/21, 19:18 Completed build in 07m 30s on Fri, 26 Mar, 07:17 PM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10374

  11. core-ci voted on patch set 3 V +1 03/26/21, 19:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1871

  12. Georg Ringer voted on patch set 3 V +2 CR +2 03/29/21, 05:01

  13. Georg Ringer merged patch set 4 03/29/21, 05:01