Review 10.4 Merged

68620[BUGFIX] Keep top level upload folder

Christian Kuhn CR +2 V +2 Easy +0 −6 updated 03/26/21, 17:05

Commit message

If a form upload is configured to save files within
"1:/user_upload/test/" (saveToFileMount: '1:/user_upload/test/'),
an upload will be saved within
"1:/user_upload/test/form_<random>/file.png".
Lateron, the DeleteUploadsFinisher delete
"1:/user_upload/test/form_<random>/file.png".
If "1:/user_upload/test/form_<random>/" is emty, this folder will be
deleted too.
This patch prevents the DeleteUploadsFinisher from trying to delete the
top level upload folder "1:/user_upload/test/".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn uploaded patch set 1 03/26/21, 16:50

  2. TYPO3com voted on patch set 1 V +1 03/26/21, 17:00 Completed build in 09m 45s on Fri, 26 Mar, 05:00 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1271

  3. core-ci voted on patch set 1 V +1 03/26/21, 17:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1866

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/26/21, 17:05

  5. Christian Kuhn merged patch set 2 03/26/21, 17:05