Review main Merged

68667[TASK] Optimize search box for record lists

Benni Mack CR +2 V +2 Normal +50 −172 updated 04/05/21, 19:51

Commit message

The search box is currently available in
* Page module (docheader)
* List module (docheader)
* Record Selector / Element Browser

All implementations are different but use the same code base:
* The outer wrapper functionality is only needed for the doc header
* The page module is not using the Fluid-based snippet

Additionally, styling is broken due to Bootstrap 5 upgrade.

The change reduces CSS and JS initialization by consolidating
the rendering of the search box and removing the buggy showLimit
functionality since there is no pagination the placeholder is not used.

Ideally, this code would be separated into a separate class
as it is only related to a fragment of DatabaseRecordList.
This is to be handled with a separate patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15