Review main Merged

68668[TASK] Clean up TypeScript code for Element Browser / Link Picker

Benni Mack CR +2 V +2 Normal +89 −144 updated 04/02/21, 18:21

Commit message

The Link Picker (RecordLinkHandler) and Element Browser logic
has been simplified to avoid jQuery where possible and to reduce
HTML rendering.

The data-icon information is never evaluated in TypeScript/JavaScript
and can be removed from any kind of HTML rendering, making the
transferred amount of HTML much smaller.

In addition, the insertElement method has been cleaned up to only
use the properties that are evaluated.

As a small side-effect, the InlineControlContainer does not
throw a console.warn if a post message cannot be evaluated
(which is typically the case for non-inline references).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16