Review main Merged

68718[TASK] Replace Mock with real instance in ReferrerEnforcerTest

Anja Leichsenring CR +2 V +2 Easy +1 −8 updated 04/07/21, 08:34

Commit message

Usage of real instances in tests avoid the awkward situation
that the test might not be useful anymore due to refactoring
and reworking over time without anyone noticing.
Mocks must only be used if necessary.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Anja Leichsenring uploaded patch set 1 04/07/21, 08:15

  2. TYPO3com voted on patch set 1 V +1 04/07/21, 08:22 Completed build in 06m 56s on Wed, 7 Apr, 08:22 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10516

  3. core-ci voted on patch set 1 V +1 04/07/21, 08:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2068

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/07/21, 08:27

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/07/21, 08:34

  6. Christian Kuhn merged patch set 2 04/07/21, 08:34