Review main Merged

68755[TASK] Cleanup setup module

Oli Bartsch CR +2 V +2 Easy +4 −19 updated 04/09/21, 19:55

Commit message

Some cleanup of the SetupModuleController:

Remove an unused function for adding Javascript,
because it has not been executed since at least 7.6
and there are other ways to add custom Javascript
nowadays. For example with an event, introduced
in #91132, or directly via PageRenderer.

Remove an unused parameter, which has been
forgotten in #93093.

Remove two superfluous typecasts.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1