68760[TASK] Provide DeletedRestrictionContainer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 913
-
Henrik Elsner uploaded patch set 1 04/12/21, 09:16
-
TYPO3com voted on patch set 1 V +1 04/12/21, 09:23 Completed build in 06m 29s on Mon, 12 Apr, 09:23 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10613
-
core-ci voted on patch set 1 V +1 04/12/21, 09:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2189
-
Georg Ringer commented on patch set 1 04/12/21, 18:34
please remove 9.5, only important bugfixes are backported! -
Henrik Elsner updated the commit message in patch set 2 04/12/21, 18:45
-
TYPO3com voted on patch set 2 V +1 04/12/21, 18:52 Completed build in 07m 01s on Mon, 12 Apr, 06:52 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10625
-
core-ci voted on patch set 2 V +1 04/12/21, 18:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2203
-
Benni Mack commented on patch set 2 04/16/21, 12:37
Core in BE usually did a "removeAll()->addRestriction()..." - what would be the benefit of this addition? -
Henrik Elsner commented on patch set 2 04/16/21, 12:55
Reply Unresolved
Benefit would be that we could create a QueryBuilder instance directly with the deleted constraint. The DefaultRestrictionContainer works most of the time, also the FE one is good for usages within the FE context. Whats missing is the container for usage in BE or API usages, where hidden & start-/endtime are not needed to. Benefit would be that the instance can be created via construct argument and without the removeAll()... etc. - depends if that benefit is big enough -
Christian Kuhn commented on patch set 2 CR -1 04/27/21, 21:10
Thanks for the patch. I'm aware the container approach is not ideal and it's in most cases still necessary a developer thinks about which restrictions are necessary in specific cases. I see no huge benefit with this container, though: It suggests things are easier for developers with the patch, but that's not the case: dev's still need to think about restrictions, for instance if workspace restrictions are needed. I tend to not add this patch - there aren't too many use cases and it may lead to even worse restrictions in practice. What do you think? -
Benni Mack wrote 04/28/21, 08:01
Removed reviewer Benni Mack. -
Anja Leichsenring commented on patch set 2 06/22/21, 18:50
Hi Henrik, sorry to say this patch will not find consensus here and won't make it. I will abandon it now. Thank you for your work nonetheless, it is highly appreciated. -
Anja Leichsenring abandoned the change 06/22/21, 18:51