Review main Merged

68843[TASK] Update @popperjs/core to match bootstrap v5 requirements

Benjamin Franzke CR +2 V +2 Easy +9 −4 updated 04/26/21, 07:37

Commit message

This fixes a warning during `yarn install`, which revealed
that we used an unsupported version of @popperjs/core:

  warning " > bootstrap@5.0.0-beta3" has incorrect peer
              dependency "@popperjs/core@^2.9.1".

bootstrap@5.0.0-beta3 contains a peerDependency to
@popperjs/core@^2.9.1 and because @types/bootstrap still
depends on @popperjs/core@2.6.0, we need to be explicit
about the desired @popperjs/core version.

Commands executed:
  yarn add @popperjs/core@^2.9.1
  grunt build

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 715

  1. Benjamin Franzke uploaded patch set 1 04/22/21, 12:53

  2. Mathias Brodala updated the commit message in patch set 2 04/22/21, 12:54

  3. TYPO3com voted on patch set 1 V +1 04/22/21, 13:00 Completed build in 06m 55s on Thu, 22 Apr, 01:00 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10802

  4. core-ci voted on patch set 1 V +1 04/22/21, 13:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10599

  5. TYPO3com voted on patch set 2 V +1 04/22/21, 13:06 Completed build in 11m 35s on Thu, 22 Apr, 01:06 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10804

  6. core-ci voted on patch set 2 V +1 04/22/21, 13:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10601

  7. Benjamin Franzke uploaded patch set 3 04/24/21, 06:55

  8. Benjamin Franzke uploaded patch set 4 04/24/21, 07:01

  9. TYPO3com voted on patch set 3 V -1 04/24/21, 07:03 Completed build in 07m 48s on Sat, 24 Apr, 07:03 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10853

  10. TYPO3com voted on patch set 4 V +1 04/24/21, 07:06 Completed build in 05m 24s on Sat, 24 Apr, 07:06 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10854

  11. core-ci voted on patch set 3 V +1 04/24/21, 07:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10675

  12. core-ci voted on patch set 4 V +1 04/24/21, 07:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10676

  13. Benni Mack voted on patch set 4 V +1 CR +1 04/26/21, 07:35

  14. Richard Haeser voted on patch set 4 V +2 CR +2 04/26/21, 07:37

  15. Richard Haeser merged patch set 5 04/26/21, 07:37