Review main Merged

68927[TASK] Remove clearable related wrap from MFA providers

Oli Bartsch CR +2 V +2 Easy +2 −6 updated 04/30/21, 10:03

Commit message

The input field of both, TOTP and recovery codes,
was wrapped into a container having `form-control`
and `form-control-clearable` classes set.

Those classes have no effect, since they belong to
the clearable functionality of TYPO3 and will be added
automatically on initialization. Since MFA does not use
this functionality, the container is removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/30/21, 00:04

  2. core-ci voted on patch set 1 V +1 04/30/21, 00:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10951

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/30/21, 09:07

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/30/21, 10:03

  5. Benni Mack merged patch set 2 04/30/21, 10:03