Review main Merged

68928[BUGFIX] Add active class to correct element in EXT:workspaces

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 04/30/21, 11:06

Commit message

The tablist inside the element information modal
in the workspaces module did not longer set the
active state on the correct tab item.

This is due to a change in bootstrap 5, since an
active tab is highlighted by setting the `active`
class on the tab item link (`nav-link`) instead of
the tab item (`nav-item`) itself.

This is fixed by adding the `active` class to the
correct element again.

Further reference:
https://getbootstrap.com/docs/5.0/components/navs-tabs

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2