Review main Abandoned

68929[WIP][BUGFIX] Handle SQL limits with workspace overlays in PHP

Benni Mack CR 0 V 0 Easy +29 −18 updated 04/30/21, 16:09

Commit message

Workspace overlays need to be applied manually (after a DB query is set),
however if Extbase is doing a ->getFirst() call, then the SQL query would
be limited to exactly one result, which might be a delete placeholder
in the DB, resulting in actually no result, instead of a newly created
workspaced version.

The typical example is a IRRE child (added as Extbase domain property)
with a news image which gets replaced in a workspace by completely
different image.

However, this also applies to any kind of IRRE relations with Extbase
in Workspaces (ex: sort IRRE children from bottom to top in workspaces).

Currently, as TYPO3 uses the Overlays logic, there is no other way
around than to fetch all records from the DB, overlaying all in a workspace
and then reducing the result set to the ones that are still valid
after doing overlays.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 1